Keyed collections #962
Closed
Keyed collections #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-shi
reviewed
Oct 12, 2024
| nextIndex = data.length | ||
|
|
||
| const vObject: InternalProxyObject<K, V> = { | ||
| data, |
There was a problem hiding this comment.
We need this not to rely on data.length.
Suggested change
| data, | |
| data, | |
| nextIndex, |
| const k = maybeProxify(key) | ||
| if (!indexMap.has(k) && !isProxy(this)) { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-expressions | ||
| this.data.length |
There was a problem hiding this comment.
and this.
Suggested change
| this.data.length | |
| this.nextIndex |
Comment on lines
+47
to
+49
| if (this.data[index] !== undefined) { | ||
| return this.data[index]![1] | ||
| } |
There was a problem hiding this comment.
let's simplify unless there's a serious issue.
Suggested change
| if (this.data[index] !== undefined) { | |
| return this.data[index]![1] | |
| } | |
| return this.data[index]![1] |
| const isProxy = (x: any) => proxyStateMap.has(x) | ||
|
|
||
| type InternalProxyObject<K, V> = Map<K, V> & { | ||
| data: Array<[K, V | undefined]> |
There was a problem hiding this comment.
Suggested change
| data: Array<[K, V | undefined]> | |
| data: Array<[K, V | undefined]> | |
| nextIndex: number |
|
|
||
| type InternalProxyObject<K, V> = Map<K, V> & { | ||
| data: Array<[K, V | undefined]> | ||
| size: number |
There was a problem hiding this comment.
The type definition? I could declare it when I create vObject below if you prefer that
There was a problem hiding this comment.
I mean I thought Map<K, V> type already includes size property.
|
|
||
| Object.defineProperties(proxiedObject, { | ||
| size: { enumerable: false }, | ||
| data: { enumerable: false }, |
There was a problem hiding this comment.
Suggested change
| data: { enumerable: false }, | |
| nextIndex: { enumerable: false }, |
|
please create a new branch in this repo and open a new pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Bug Reports or Discussions
#943
Fixes #
N/A
Summary
Created new implementation for proxyMap and proxySet. Added benchmarks and a few new tests.
Check List
pnpm run prettierfor formatting code and docs