Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vanilla): revert #970 #986

Merged
merged 4 commits into from
Nov 5, 2024
Merged

fix(vanilla): revert #970 #986

merged 4 commits into from
Nov 5, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 30, 2024

Related Bug Reports or Discussions

Fixes #985

Summary

I thought #970 change was okay, but it wasn't. Added a few tests to keep it.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

codesandbox-ci bot commented Oct 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Oct 30, 2024

Open in Stackblitz

More templates

pnpm add https://pkg.pr.new/valtio@986

commit: ade957a

Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 11:15am

Copy link

github-actions bot commented Oct 30, 2024

Size Change: +21 B (+0.15%)

Total Size: 13.6 kB

Filename Size Change
./dist/esm/vanilla.mjs 2.35 kB +10 B (+0.43%)
./dist/vanilla.js 2.38 kB +11 B (+0.46%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 691 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla/utils.mjs 3.14 kB
./dist/index.js 243 B
./dist/react.js 681 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla/utils.js 3.17 kB

compressed-size-action

@dai-shi dai-shi merged commit bbe3c3a into main Nov 5, 2024
29 checks passed
@dai-shi dai-shi deleted the bug-985 branch November 5, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant