fix: should use Object.is to compare two value (#1314)

pmndrs · Oct 9, 2022 · ae4cc7f · ae4cc7f
1 parent 43ea18e
commit ae4cc7f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/vanilla.ts b/src/vanilla.ts
@@ -72,7 +72,7 @@ const createStoreImpl: CreateStoreImpl = (createState) => {
       typeof partial === 'function'
         ? (partial as (state: TState) => TState)(state)
         : partial
-    if (nextState !== state) {
+    if (!Object.is(nextState, state)) {
       const previousState = state
       state =
         replace ?? typeof nextState !== 'object'

diff --git a/tests/basic.test.tsx b/tests/basic.test.tsx
@@ -437,6 +437,17 @@ it('can set the store', () => {
   expect(getState().value).toBe(5)
 })
 
+it('both NaN should not update', () => {
+  const { setState, subscribe } = create<number>(() => NaN)
+
+  const fn = jest.fn()
+  subscribe(fn)
+
+  setState(NaN)
+
+  expect(fn).not.toBeCalled()
+})
+
 it('can set the store without merging', () => {
   const { setState, getState } = create<{ a: number } | { b: number }>(
     (_set) => ({