Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add jest-dom matchers and eslint plugin #2850

Merged

Conversation

kretajak
Copy link
Contributor

@kretajak kretajak commented Nov 11, 2024

Summary

Testing Library provides nice set of custom matchers that are more declarative and easier to understand. Along with @testing-library/jest-dom there is an accompanying eslint-plugin-jest-dom which enforce using these selectors.

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 9:41pm

Copy link

codesandbox-ci bot commented Nov 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi merged commit 5a8842f into pmndrs:main Nov 13, 2024
26 checks passed
@kretajak kretajak deleted the use-jest-dom-matchers-and-eslint-plugin-jest-dom branch November 13, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants