info: fix ULTs stacks dump works only once #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1/one returned value must be tested instead of 0 to detect that last "parked" XStream is done in ABTI_info_check_print_all_thread_stacks() and thus that print_stack_flag can be reset to PRINT_STACK_FLAG_UNSET to allow for a next dump to be started. DAOS-14248 ticket, Argobots issue pmodels#393. Signed-off-by: Bruno Faccini <bruno.faccini@intel.com>
yfguo
approved these changes
Sep 26, 2023
|
@bfaccini I see the PR is created as draft. Is this still a work-in-progress? |
Nope sorry, this is only because I always submit PRs as draft just waiting for testing to complete and have forgotten to make it a "ready for review" !! |
4 tasks
|
See #397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
1/one returned value must be tested instead of 0 to detect that last "parked" XStream is done in
ABTI_info_check_print_all_thread_stacks() and thus that print_stack_flag can be reset to PRINT_STACK_FLAG_UNSET
to allow for a next dump to be started.
References: DAOS-14248 ticket, Argobots issue #393.
Checklist
module: short descriptionand follows good practice