Skip to content

Commit

Permalink
[DO NOT MERGE] ch4/ucx: Support GPU buffers as window memory
Browse files Browse the repository at this point in the history
Recent versions of UCX handle this case correctly.
  • Loading branch information
raffenet committed Nov 10, 2023
1 parent bfa146d commit b5e9059
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions src/mpid/ch4/netmod/ucx/ucx_win.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,7 @@ static int win_allgather(MPIR_Win * win, size_t length, uint32_t disp_unit, void

MPIDI_UCX_WIN(win).mem_mapped = false;

/* As of ucx-1.10, mapping with a CUDA device buffer may be successful but
* later RMA segfaults inside UCX. Thus, MPICH manually disables native RMA for device win buffer for now.*/
if (MPIR_GPU_query_pointer_is_dev(*base_ptr)) {
status = UCS_ERR_UNSUPPORTED;
} else {
status = ucp_mem_map(MPIDI_UCX_global.context, &mem_map_params, &mem_h);
}

status = ucp_mem_map(MPIDI_UCX_global.context, &mem_map_params, &mem_h);
/* some memory types cannot be mapped, skip rkey packing */
if (status != UCS_ERR_UNSUPPORTED) {
MPIDI_UCX_CHK_STATUS(status);
Expand Down

0 comments on commit b5e9059

Please sign in to comment.