Fix defects found in Coverity Scan for MPICH-CH4 #6745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test:mpich/ch4/most |
dycz0fx
force-pushed
the
fix_topo
branch
2 times, most recently
from
ce8eb0f
to
fd039cb
Compare
|
test:mpich/ch4/most |
dycz0fx
force-pushed
the
fix_topo
branch
4 times, most recently
from
d0ef6e2
to
84a1eb0
Compare
|
@dycz0fx Please add commit messages describe what each commit is trying to fix |
|
@hzhou Thanks for the reminder! I have added the description in the commits. |
|
test:mpich/ch4/most |
dycz0fx
force-pushed
the
fix_topo
branch
4 times, most recently
from
f2be88b
to
60e6c99
Compare
The commit addresses the following issues: Error handling issues in MPII_Treeutil_tree_knomial_2_init() Null pointer dereferences in init_root_switch() Control flow issues in MPII_Treeutil_tree_topology_aware_k_init() Null pointer dereferences in MPII_Treeutil_tree_topology_wave_init() Control flow issues in MPII_Treeutil_tree_kary_init_topo_aware()
This commit addresses the following issues: Resource leaks in pmix_init() Error handling issues in parse_coord_file() Insecure data handling in parse_coord_file()
Fix uninitialized variables in MPIDI_OFI_send()
|
test:mpich/ch4/gpu |
abrooks98
approved these changes
Mar 19, 2024
|
test:mpich/ch4/gpu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix defects found in Coverity Scan for MPICH-CH4
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.