Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coll: remove errflag propagation #7045

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Conversation

hzhou
Copy link
Contributor

@hzhou hzhou commented Jun 28, 2024

Pull Request Description

Propagating errors in collectives rather than locally aborting adds tons of maintenance cost with very little proved benefits. I personally often waste days in debugging simply due to the difficulty of pin-pointing the source of error. With local aborting, our error ring shows the error traceback. The error propagation loses this error trail, and propagates the error with limited information to remote places -- that is just evil.

Of course, this is a draft PR for the purpose of discussion.
[skip warnings]

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@hzhou hzhou force-pushed the 2406_errflag branch 2 times, most recently from 75fc557 to 23c8399 Compare June 28, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant