ch4/ofi: use cq_data to carry message size #7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhou
force-pushed
the
2409_am_data
branch
5 times, most recently
from
67978a2
to
5af8c7c
Compare
hzhou
force-pushed
the
2409_am_data
branch
2 times, most recently
from
f2a8b88
to
fd200e6
Compare
hzhou
changed the title
hzhou
force-pushed
the
2409_am_data
branch
3 times, most recently
from
6d7f873
to
6490589
Compare
This was a leftover when we refactored dynamic process handshake in 1e7e5ce.
It's an optional feature that we can take advantage of, e.g. carry more meta data.
raffenet
approved these changes
Nov 5, 2024
If we have 8-byte cq_data, we can use the higher bits to carry data_sz.
This saves a round trip for MPI_{Probe,Mprobe,Iprobe,Improbe}.
Temporary turn this on for testing purpose.
|
test:mpich/ch4/most |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Following #7192, if the provider supports 64-bit
cq_data, we can carry thedata_szin thecq_data(up to 4GB), which can save a roundtrip for probing.Diagrams
[skip warnings]
TODOs
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.