New command: remove enterprise application. #6127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @Saurabh7019, we'll try to review it ASAP! |
milanholemans
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Well done @Saurabh7019, we're almost there. Let's first change some things before we continue.
src/m365/entra/commands/enterpriseapp/enterpriseapp-remove.spec.ts
Outdated
Show resolved
Hide resolved
|
Hi @Saurabh7019, as discussed here: #6155, I think we should rename the options. Sorry for that! |
milanholemans
requested changes
Aug 3, 2024
milanholemans
approved these changes
Aug 6, 2024
Comment on lines
+147
to
+152
| let spMatchQuery: string = ''; | ||
| if (options.displayName) { | ||
| spMatchQuery = `displayName eq '${formatting.encodeQueryParameter(options.displayName)}'`; | ||
| } | ||
|
|
||
| const spItemsResponse = await odata.getAllItems<{ id: string }>(`${this.resource}/v1.0/servicePrincipals?$filter=${spMatchQuery}&$select=id`); |
There was a problem hiding this comment.
Can't we merge this code together now?
Comment on lines
+196
to
+202
| sinon.stub(request, 'get').callsFake(async (opts) => { | ||
| if (opts.url === `https://graph.microsoft.com/v1.0/servicePrincipals?$filter=appId eq '65415bb1-9267-4313-bbf5-ae259732ee12'&$select=id`) { | ||
| return spAppInfo; | ||
| } | ||
|
|
||
| throw 'Invalid request'; | ||
| }); |
There was a problem hiding this comment.
We don't need this stub anymore, right?
|
Merged manually, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6111