Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --force option to spo site appcatalog remove command. Closes #6091 #6136

Closed
wants to merge 1 commit into from

Conversation

Saurabh7019
Copy link
Contributor

Closes #6091

@Saurabh7019 Saurabh7019 marked this pull request as ready for review July 10, 2024 09:17
@milanholemans milanholemans added the pr-major PR for the next major release label Jul 10, 2024
@milanholemans
Copy link
Contributor

Thank you @Saurabh7019!

@Adam-it
Copy link
Contributor

Adam-it commented Jul 10, 2024

hi, this PR is now targeting v9.
But it does not mean this PR will be somehow on-hold. We just identified a breaking change issue we want to release ASAP with next major that's why we plan to release v8 a lot sooner to unblock our users with Power Automate commands.
v9 target is will be released shortly after (as planned), which most probably will be the end of September.
Thank you once again for your truly amazing effort in helping us build the best CLI in the world 👏😍. You Rock 🤩

@milanholemans
Copy link
Contributor

Hi, since we had to align our v9 branch with the latest v8, some merge conflicts crept into your PR. Could you realign your changes with the latest v9, please? If you need any assistance, don't hesitate to ping us.

@Adam-it
Copy link
Contributor

Adam-it commented Aug 3, 2024

@Saurabh7019 seems like something got wrong here. Your branch is now adding two commits which are not part of this change and as a result in the changed files of this PR's I think I see files that should not be here.
May I kindly ask you to try to rebase with latest v9 and clear out those changes?
Alternatively, if this will not work please open a new PR with cherry-picked commit only with your change and tag me in a comment of this PR so I will got with its review ASAP.
Thanks a ton for your constant support and awesome work for the community 👏. You Rock 🤩.
Let me know if you need any help 👍

@Saurabh7019
Copy link
Contributor Author

Hi @Adam-it, I have rebased it onto the latest v9 and removed the unrelated commits.

@Saurabh7019 Saurabh7019 marked this pull request as ready for review August 5, 2024 07:23
Copy link
Contributor

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect 👏😍

@Adam-it
Copy link
Contributor

Adam-it commented Aug 11, 2024

ready to merge 🚀

@Adam-it
Copy link
Contributor

Adam-it commented Aug 11, 2024

Merged manually. You Rock 👏🤩

@Adam-it Adam-it closed this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-major PR for the next major release pr-merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants