Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes duplicate property for "teams tab list" command. Closes #5900 #6151

Open
wants to merge 26 commits into
base: v10
Choose a base branch
from
Open

Removes duplicate property for "teams tab list" command. Closes #5900 #6151

wants to merge 26 commits into from

Conversation

SmitaNachan
Copy link
Contributor

Removes duplicate property called teamsAppTabId for teams tab list command. Closes #5900

@milanholemans
Copy link
Contributor

Thank you!

@milanholemans milanholemans added the pr-major PR for the next major release label Jul 14, 2024
@milanholemans
Copy link
Contributor

Hi, since we had to align our v9 branch with the latest v8, some merge conflicts crept into your PR. Could you realign your changes with the latest v9, please? If you need any assistance, don't hesitate to ping us.

@milanholemans milanholemans marked this pull request as draft July 31, 2024 14:01
@SmitaNachan SmitaNachan marked this pull request as ready for review August 11, 2024 09:12
@milanholemans
Copy link
Contributor

Hi @SmitaNachan, could you also update the v9 upgrade guidance and recheck our sample scripts for needed changes, please? Much appreciated 🙏

@milanholemans milanholemans marked this pull request as draft August 12, 2024 09:37
@SmitaNachan SmitaNachan marked this pull request as ready for review August 23, 2024 15:21
@milanholemans milanholemans self-assigned this Aug 24, 2024
milanholemans
milanholemans requested changes Aug 24, 2024
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SmitaNachan, in the comments of the issue we discussed that the extra property has to disappear only for JSON output. For other outputs, this might still be useful for people. Could you update the PR accordingly?

@milanholemans milanholemans marked this pull request as draft August 24, 2024 19:32
@Adam-it
Copy link
Contributor

Adam-it commented Aug 30, 2024

Due to an upcoming breaking change connected to CLI for Microsoft 365 login experience we will need to do a v9 release a bit sooner than we anticipated. Due to that we had to change the target of this PR to v10 which will be the next regular major release.

@milanholemans
Copy link
Contributor

Hi @SmitaNachan did you have some time to resolve the conflicts and process the last feedback?

@SmitaNachan SmitaNachan marked this pull request as ready for review September 9, 2024 11:26
@SmitaNachan
Copy link
Contributor Author

Hi @milanholemans
Ready for review

nanddeepn and others added 22 commits September 11, 2024 23:51
@nanddeepn @MathijsVerbeeck
Updates option names of 'app permission add' to plural. Closes pnp#5719
8074763
@nanddeepn @MathijsVerbeeck
Removes deprecated Guest value from 'aad m365group user list' command. …
d27e2ff 
…Closes pnp#5558
@Saurabh7019 @MathijsVerbeeck
Adds --force option to 'spo site appcatalog remove' command. Closes p…
cf3d43a 
…np#6091
@nanddeepn @MathijsVerbeeck
Aligns options with naming convention. Closes pnp#5616
44b7822
@SmitaNachan @MathijsVerbeeck
Removes duplicate property from 'spo list list' command. Closes pnp#6042
d0d6d22
@nanddeepn @MathijsVerbeeck
Updates 'spo tenant recyclebinitem restore' command. Closes pnp#6063
fc07529
@Adam-it @MathijsVerbeeck
Updates upgrade guidance
07d12fb
@Adam-it @MathijsVerbeeck
Updates release notes
92bd2ef
@nanddeepn @MathijsVerbeeck
Removes deprecated option '--wait' from 'spo site remove' command. Cl…
58a49d9 
…oses pnp#5956
@milanholemans @MathijsVerbeeck
Reworks command 'spo file copy' to new API endpoint. Closes pnp#6152
e5675ad
@nanddeepn @MathijsVerbeeck
Removes deprecated CLI environment variables. Closes pnp#5918
50e7949
@nanddeepn @MathijsVerbeeck
Updates options of 'entra enterpriseapp' commands. Closes pnp#6155
139474e
@SmitaNachan @MathijsVerbeeck
Removes 'overwrite' option from 'spfx project github workflow add' co…
abb82ba 
…mmand. Closes pnp#5765
@nanddeepn @MathijsVerbeeck
Updates 'm365 status' command output. Closes pnp#5849
8d9d733
@SmitaNachan @MathijsVerbeeck
Removes 'spo folder rename' alias. Closes pnp#5911
a65aee5
@Adam-it @MathijsVerbeeck
Updates release notes
83394dc
@SmitaNachan @MathijsVerbeeck
Fixes Rights property from 'spo applicationcustomizer get' command. C…
46eac8d 
…loses pnp#6052
@SmitaNachan @MathijsVerbeeck
Removed yammer command aliases. Closes pnp#5764
d3422cc
@milanholemans @MathijsVerbeeck
Updates release notes
ab4cab1
@MathijsVerbeeck
Removes showSpinner config variable. Closes pnp#6126
e9dfc38
@MathijsVerbeeck
Aligns options for 'spo contenttype field' commands. Closes pnp#6170
19c41a2
@milanholemans @MathijsVerbeeck
Updates release notes
a4e89de
@SmitaNachan
Copy link
Contributor Author

Hi @milanholemans
Can you please review and merge, before there are any more conflicts to resolve 😁

@milanholemans
Copy link
Contributor

Yes, I was planning to merge it soon when merging PRs with main. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans milanholemans requested changes

Assignees

@milanholemans milanholemans

Labels
pr-major PR for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SmitaNachan @milanholemans @Adam-it @nanddeepn @Saurabh7019 @MathijsVerbeeck