Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated option "--wait" from "spo site remove" command. Closes #5956 #6212

Closed
wants to merge 1 commit into from

Conversation

nanddeepn
Copy link
Contributor

Remove deprecated --wait option from spo site remove command. Closes #5956

@Jwaegebaert
Copy link
Contributor

Hey @nanddeepn, first, I want to thank you for all your hard work on the v9 major PRs. Your effort is really appreciated, and we're grateful for your dedication to these projects.

We’ve noticed some merging issues lately, which are expected with major PRs. However, when these PRs become difficult, closing and reopening new ones isn't ideal. It makes it hard for us to track reviews and isn’t sustainable long-term. An easy way out is, of course, creating a new PR on a new branch with the same changes, but this complicates our process and can be frustrating for both sides.

Remember, a PR is never beyond repair. @milanholemans wrote an extensive guide that should be very helpful in these situations. (#6164 (comment)) If you still need assistance, please don’t hesitate to ping @arjunumenon. He's available to sync and help resolve any issues you encounter.

Thanks again for your dedication and hard work on the v9 major PRs. We truly appreciate everything you're doing.

@nanddeepn nanddeepn closed this Aug 9, 2024
@nanddeepn nanddeepn deleted the issue-5956-1 branch August 9, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-major PR for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants