Adds command flow recyclebinitem list
#6214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanholemans
force-pushed
the
flow-recyclebinitem-list
branch
from
998e9fd
to
4b24a23
Compare
milanholemans
force-pushed
the
flow-recyclebinitem-list
branch
from
4b24a23
to
40a1617
Compare
milanholemans
changed the title
flow recyclebinitem list
MathijsVerbeeck
requested changes
Aug 15, 2024
|
|
||
| describe(commands.OWNER_LIST, () => { | ||
| const environmentName = 'Default-d87a7535-dd31-4437-bfe1-95340acd55c6'; | ||
|
|
There was a problem hiding this comment.
Let's remove this empty line
Comment on lines
+213
to
+224
| it('correctly retrieves deleted flows with output json', async () => { | ||
| sinon.stub(request, 'get').callsFake(async (opts) => { | ||
| if (opts.url === `https://api.flow.microsoft.com/providers/Microsoft.ProcessSimple/scopes/admin/environments/${formatting.encodeQueryParameter(environmentName)}/v2/flows?api-version=2016-11-01&include=softDeletedFlows`) { | ||
| return flowResponse; | ||
| } | ||
|
|
||
| throw 'Invalid request'; | ||
| }); | ||
|
|
||
| await command.action(logger, { options: { verbose: true, environmentName: environmentName } }); | ||
| assert.deepStrictEqual(loggerLogSpy.firstCall.args[0], deletedFlows); | ||
| }); |
There was a problem hiding this comment.
Couldn't we combine this assert with the first json test? Now we are doing the exact same
Comment on lines
+226
to
+240
| it('correctly retrieves deleted flows with output text', async () => { | ||
| sinon.stub(request, 'get').callsFake(async (opts) => { | ||
| if (opts.url === `https://api.flow.microsoft.com/providers/Microsoft.ProcessSimple/scopes/admin/environments/${formatting.encodeQueryParameter(environmentName)}/v2/flows?api-version=2016-11-01&include=softDeletedFlows`) { | ||
| return flowResponse; | ||
| } | ||
|
|
||
| throw 'Invalid request'; | ||
| }); | ||
|
|
||
| await command.action(logger, { options: { verbose: true, environmentName: environmentName, output: 'text' } }); | ||
| const textResponse = deletedFlows.map(flow => ({ ...flow, displayName: flow.properties.displayName })); | ||
|
|
||
| assert.deepStrictEqual(loggerLogSpy.firstCall.args[0], textResponse); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Couldn't we combine this assert with the first text test? Now we are doing the exact same
There was a problem hiding this comment.
You want to merge 2 tests? They are doing the same indeed but testing something different. AFAIK, in an ideal world, a test should have only 1 assert, so it checks exactly 1 thing.
MathijsVerbeeck
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6139