Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial build #11

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Initial build #11

merged 3 commits into from
Aug 16, 2023

Conversation

StuartBaxter-MVP
Copy link
Contributor

@StuartBaxter-MVP StuartBaxter-MVP commented Aug 9, 2023

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <name@example.com>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Initial submission of the Dataverse security toolkit

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

Submitter Guidance (DELETE AFTER READING)

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.

Pull requests that do not follow this template will be automatically rejected.

Please target your PR to main branch.

Remember that this repository is maintained by community members who volunteer their time to help. Be courteous and patient.

(DELETE THIS SECTION AFTER READING)

@StuartBaxter-MVP
Copy link
Contributor Author

This is my first sample, so please reach out if I need to change anything

@Laskewitz Laskewitz removed their assignment Aug 10, 2023
@Laskewitz Laskewitz self-assigned this Aug 16, 2023
@Laskewitz Laskewitz self-requested a review August 16, 2023 14:10
Copy link
Member

@Laskewitz Laskewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @StuartBaxter-MVP - great submission. Looks like a great solution for people.

I fixed some things like the readme, regenerated the solution, and imported it in my environment.

There was a little error (see screenshot below) when I opened the app at the top, but nothing major to hold this one back. If you want, you can create a new PR to fix the error and I'll look at that as well.

image

Thanks for your hard work!

@Laskewitz Laskewitz merged commit a50b104 into pnp:main Aug 16, 2023
@StuartBaxter-MVP
Copy link
Contributor Author

StuartBaxter-MVP commented Aug 18, 2023 via email

@StuartBaxter-MVP
Copy link
Contributor Author

StuartBaxter-MVP commented Oct 17, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants