Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_depth implementation #101

Merged
merged 2 commits into from
Nov 6, 2024
Merged

max_depth implementation #101

merged 2 commits into from
Nov 6, 2024

Conversation

antalgu
Copy link
Contributor

@antalgu antalgu commented Nov 5, 2024

max_depth option for whois and ai_whois queries.

max_depth option for whois and ai_whois queries.
@pogzyb
Copy link
Owner

pogzyb commented Nov 5, 2024

The more I look at it, the more I'm not a fan of this parameter as an integer. Ideally, you'd just want the "first" response from the given TLD server and then stop. Making this a simple boolean param might be better.

I created this branch, do-max-depth, off of your commits and added my changes. Test this out and let me if this still produces good results.

@antalgu
Copy link
Contributor Author

antalgu commented Nov 6, 2024

Yeah, works for us. It produces good results, go ahead with the changes.
I think there's a residual depth in aio_do_query however, can you take it out?

self, server: str, data: str, regex: str, chain: list[str], depth: int = 0

Thanks for everything!

@pogzyb pogzyb merged commit a2f87f3 into pogzyb:main Nov 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants