Adding Windows CI #116
Adding Windows CI #116
Conversation
|
Looks like these tests work on the 5.9 toolchain without issue, but not 5.8, @mbrandonw what would you like to do here. I can probably just use the 5.9 toolchain since that's scheduled to come out with Xcode 15 sometime soon is and would put mac and Windows on the same level, or I can try to install the local 5.8 toolchain on my windows machine and debug a bit more. Dunno how you are all thinking about backward compatibility on Windows. |
|
Ran these tests locally with the 5.8.1 toolchain which is the most current, non-development toolchain and everything seems to pass there so I bumped the config to that. |
|
Hi @brianmichel, thanks for this! If you can't figure out why 5.8.1 is still failing on CI, feel free to bump to 5.9 if that gets things passing. |
|
@mbrandonw yeah it's on my list this week, just getting sidetracked by some C++ Interop stuff that's blocking our project which took precedence. 🤞 it's an easy fix to get this to pass! |
|
Hey @mbrandonw looks like there was some bug preventing running the tests in a release config, so I've broken out the build phases and the test phases to try to get a good balance of coverage on the profiles. |
brianmichel
force-pushed
the
brian/add-windows-ci
branch
from
95a129f
to
d9601a0
Compare
|
@mbrandonw looks like this should be good now, had to make a couple adjustments but left comments where I did |
There was a problem hiding this comment.
Hi @brianmichel looks great, thanks for figuring out the edge cases! Once Swift 5.9 is available on Windows we can revisit bringing back release testing too.
We want to setup Windows CI for all of the Pointfree repos that are used in TCA to ensure that we have cross platform compatibility going forward (or at least to ensure that nothing breaks).