Fix some DocC warnings. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
commented
Jul 31, 2024
| @@ -14,5 +14,4 @@ | |||
| ### Partial case paths | |||
|
|
|||
| - ``PartialCaseKeyPath`` | |||
| - ``Swift/PartialKeyPath/callAsFunction(_:)`` | |||
There was a problem hiding this comment.
I don't think this actually exists. Is this old?
There was a problem hiding this comment.
Looks like it moved to _AppendKeyPath to properly work. Maybe doesn't need to be documented though.
mbrandonw
commented
Jul 31, 2024
| @@ -227,7 +227,7 @@ public func XCTUnwrap<Enum, Case>( | |||
| Actual: | |||
| \(String(describing: `enum`)) | |||
| """, | |||
| file: file, | |||
| file: (file), | |||
There was a problem hiding this comment.
I think we want to silence this warning right?
⚠️ Parameter 'file' with default argument '#file' passed to parameter 'file', whose default argument is '#filePath'
There was a problem hiding this comment.
I think the way to silence this is to stop using #file since its behavior changes in Swift 6 language mode and instead use #filePath explicitly.
stephencelis
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to clean up some warnings that have accumulated.