Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix naming consistancy accross pointfree libs #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

doozMen
Copy link

@doozMen doozMen commented Sep 6, 2024

There is an issue when using case-paths and
When you already use the swift-issue-reporting dependency by using the url for swift-issue reporting.

I wrongly described the issue to be snapshot testing. I was having an unrelated issue with that and confused it here.

The issue is that in swift 6 a swift package containing a reference to the same package but with different url results in an error where this previously was a warning.
So the name can stay but could you change the url?

Or you could also close my PR as simply removing my dependency on issue reporting and reusing the one from case-path worked too

stijn added 2 commits September 6, 2024 13:17
There is an issue when using case-paths and
snapshot testing that both have different
url's pointing to the issue reporting
package.
@stephencelis
Copy link
Member

@doozMen Snapshot Testing doesn't depend on Issue Reporting at all:

https://github.com/pointfreeco/swift-snapshot-testing/blob/main/Package.swift

Can you explain the conflict you're seeing and share a project that demonstrates the issue?

We currently lock to xctest-dynamic-overlay as the package name because it's the only way to support things in our package ecosystem in a backwards-compatible way. In the future we will split these two packages out to better address the issue, but unfortunately do not think we can merge this PR without breaking things for folks.

@doozMen
Copy link
Author

doozMen commented Sep 6, 2024

I updated the description. I mixed 2 unrelated issues I had I'm afraid. Please let me know if this is clear enough or if I should make a small package that reproduces the confusing issue whether using swift 6

@stephencelis
Copy link
Member

@doozMen For now you must specify xctest-dynamic-overlay to work around the problem. In the future we will be able to fix this by splitting the package into 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants