Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated parameter name #111

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix deprecated parameter name #111

merged 2 commits into from
Oct 2, 2024

Conversation

zunda-pixel
Copy link
Contributor

No description provided.

stephencelis
stephencelis approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll probably hold off on merging this immediately since beta 5 is still relatively new, but maybe when beta 6 drops we can start updating these.

@zunda-pixel zunda-pixel marked this pull request as ready for review August 8, 2024 23:37
@zunda-pixel
Copy link
Contributor Author

I confirmed Xcode 16.1 beta 1(16B5001e) can build this code.

@stephencelis
Does Package@swift-6.0.swift need swiftLanguageModes?

@stephencelis
Copy link
Member

@zunda-pixel The main issue is that swiftLanguageModes doesn't build in Xcode 16 beta 4 and below, so this would break for folks that haven't updated to the latest Xcode yet. So no harm in holding off on merging this PR for now, but we will merge it in the future.

@mbrandonw mbrandonw mentioned this pull request Aug 15, 2024
Closed
@zunda-pixel zunda-pixel changed the title fix parameter name fix deprecated parameter name Sep 7, 2024
stephencelis
stephencelis approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This should be good to go now!

@stephencelis stephencelis merged commit 770f990 into pointfreeco:main Oct 2, 2024
13 checks passed
@zunda-pixel zunda-pixel deleted the fix-parameter branch October 2, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencelis stephencelis stephencelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zunda-pixel @stephencelis