Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address build issues occurring when building with Library Evolution support, Xcode 16 #133

Conversation

gemmakbarlow
Copy link
Contributor

Address build issues seen building for library evolution mode, Xcode 16 - i.e. via make build-for-library-evolution.

image

Address build issues seen building for library evolution mode, Xcode 16 - i.e. `make build-for-library-evolution`.
@gemmakbarlow gemmakbarlow changed the title Address build issues in Library Evolution mode Address Xcode 16 build issues with Library Evolution mode Sep 23, 2024
@gemmakbarlow gemmakbarlow changed the title Address Xcode 16 build issues with Library Evolution mode Address Xcode 16 build issues with Library Evolution support Sep 23, 2024
@gemmakbarlow gemmakbarlow changed the title Address Xcode 16 build issues with Library Evolution support Address Xcode 16 build issues occurring when building with Library Evolution support Sep 23, 2024
@gemmakbarlow gemmakbarlow changed the title Address Xcode 16 build issues occurring when building with Library Evolution support Address build issues occurring when building with Library Evolution support, Xcode 16 Sep 23, 2024
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We actually had a library evolution CI action that was still on 15.4, so I've pushed an update for it to run against Xcode 16. If things go green I'll merge!

file: IssueContext.current?.filePath ?? filePath,
line: IssueContext.current?.line ?? line
)
@unknown default: break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth reporting issues from this branch? From a practical perspective I can't see this unknown branch ever hitting, though, so this should be OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely went back-and-forth about combining this with the nil branch case somehow. I ultimately came to the same conclusion you did; unlikely to fire in practice.

@stephencelis stephencelis merged commit 6cbc73b into pointfreeco:main Sep 23, 2024
17 checks passed
@gemmakbarlow
Copy link
Contributor Author

Thanks! We actually had a library evolution CI action that was still on 15.4, so I've pushed an update for it to run against Xcode 16. If things go green I'll merge!

Oh that makes sense 😄 Awesome.

@gemmakbarlow
Copy link
Contributor Author

@stephencelis - if you're able to cut a new release and update some of the other pointfreeco SDKs to include the fix, I'd appreciate it (some build issues stemming from this currently causing me pain) 🙏🏻

Happy to help with the effort if useful !

@stephencelis
Copy link
Member

stephencelis commented Sep 23, 2024

@gemmakbarlow Done! https://github.com/pointfreeco/swift-issue-reporting/releases/tag/1.4.1

There should be no need to change our other libraries to receive the update. Just make sure you update your packages in your project so that the Package.resolved file pulls in the newer version and you should be good to go! Or you can explicitly depend on 1.4.1 in your package/project.

@gemmakbarlow
Copy link
Contributor Author

@gemmakbarlow Done! https://github.com/pointfreeco/swift-issue-reporting/releases/tag/1.4.1

There should be no need to change our other libraries to receive the update. Just make sure you update your packages in your project so that the Package.resolved file pulls in the newer version and you should be good to go! Or you can explicitly depend on 1.4.1 in your package/project.

Perfect, thanks for the tip and speedy replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants