This repository has been archived by the owner on May 14, 2021. It is now read-only.
Add a 'host' method to the application_rackup resource #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 70.12% (diff: 50.00%)@@ master #86 diff @@
==========================================
Files 13 13
Lines 307 308 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 215 216 +1
Misses 92 92
Partials 0 0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rackupon the command line defaults to listening to localhost, which does not allow outside connections. You can pass--host 0.0.0.0to rackup to allow connections on all interfaces. This PR allows this host flag to be set via thehostmethod on theapplication_rackupresource