Pep8 complience #37
Open
Pep8 complience #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort for python<=3.4 was dropped
pokidovea
reviewed
Jul 30, 2022
immobilus/logic.py
Outdated
|
|
||
| Parameters: | ||
| dt: Any | ||
| not used at the moment |
There was a problem hiding this comment.
It is not "not used at the moment". This class repeats an interface of a real timezone instance, but returns fake data.
pokidovea
reviewed
Jul 30, 2022
|
|
||
| TIME_TO_FREEZE = None | ||
| TZ_OFFSET = 0 | ||
| class Config(object): |
There was a problem hiding this comment.
Looks like it's not a Config, since values are not changeable outside. Mb smth like TemporaryData or smth similar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few pep8 oriented changes, involving compatability changes of requirements for tests not to fail or warn and logic file improvements. Actually, just scratched a tip of the iceberg - the pep8 is not fully grasped at the moment.