Fix: Remove super visibility of Pending storage in pallet-ethereum
#1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you agree with this change, can I cherry-pick to |
lemunozm
changed the title
super visibility of Pending storage in pallet-ethereum
boundless-forest
approved these changes
Mar 18, 2024
Please submit another PR. |
|
Thanks for being so fast! Here is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I guess it was a typo after removing deprecated getters. All other storages of
pallet-ethereumremove theirsupervisibility exceptPendingstorage. Blocking any interaction with it from the outside.This PR removes the
supervisibility to be able to access them from other pallets.