Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Foreign Lemma Prefixes (fix #56) #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Foreign Lemma Prefixes (fix #56) #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309ddeb
Add tests for prefix issue
polm Jul 3, 2024
0fab1bb
Fix handling of foreign lemmas that are prefixes
polm Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cutlet/cutlet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def has_foreign_lemma(word):
if not '-' in lemma:
return False

cand = lemma.split('-')[-1]
cand = lemma.split('-', 1)[-1]
# NOTE: some words have 外国 instead of a foreign spelling. ジル
# (Jill?) is an example. Unclear why this is the case.
# There are other hyphenated lemmas, like 私-代名詞.
Expand Down Expand Up @@ -257,6 +257,8 @@ def romaji_tokens(self, words, capitalize=True, title=False):
if nw and nw.feature.pos1 in ('補助記号', '接尾辞'): continue
# special case for half-width commas
if nw and nw.surface == ',': continue
# special case for prefixes
if foreign and roma[-1] == "-": continue
# 思えば -> omoeba
if nw and nw.feature.pos2 in ('接続助詞'): continue
# 333 -> 333 ; this should probably be handled in mecab
Expand Down Expand Up @@ -348,7 +350,7 @@ def romaji_word(self, word):
elif (self.use_foreign_spelling and
has_foreign_lemma(word)):
# this is a foreign word with known spelling
return word.feature.lemma.split('-')[-1]
return word.feature.lemma.split('-', 1)[-1]
elif word.feature.kana:
# for known words
kana = jaconv.kata2hira(word.feature.kana)
Expand Down
3 changes: 3 additions & 0 deletions cutlet/test/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@
("くヽる", "Ku ru"),
("今度クヾペへ行こう", "Kondo kugupe e ikou"), # made up word
("彁々", "?"),
# prefixes, see #56
("ビオハザード", "Bio-hazard"),
("イントラワード", "Intra-word"),
]

SENTENCES_KUNREI = [
Expand Down