Prism Query Interface: Replace gRPC with custom handling of messages #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may return in the future as a non-unique "client descriptor" to help admins determine who is using the interface. But for now it is no longer needed to identify client sessions (this is now done with the socket).
This fixes a rather intricate bug: The ResultIterator would use the batch size passed on creation, but the fetch code would it compare with the fetch size specified in the message. This would lead to fetch reporting isLast to early, when the fetch size in the message is different from in the initial execute message.
This way seems more logic. Unparameterized statements are still a bit of a hack, but with the async changes, it should be possible to not send the statement id, but being able to cancel calls based on the message id. While working on the loop, change to allow the ConnectionRequest only once and only as the first message.
…ypheny-DB into proto-without-grpc
|
@gartens is this ready for review and can be changed from draft, or do you have anything to add? |
|
Go ahead @datomo. |
vogti
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes gRPC in favor of sending/receiving the protobuf encoded messages ourselves. This gives us better control to rollback transactions immediately when the connection is closed, allows us to support different transport methods (TCP and UNIX) and depending on the transport to authenticate clients directly (UNIX).
Various messages and serializations are improved as well.
Additional Changes
Fixes
ToDo