Improve Locking for Transactions and Increased Handling of Errors #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to better-locking
They are very common for benchmarks like YCSB and are already logged by the rollback, so do not log them again.
…ny-DB into better-locking
gartens
reviewed
Oct 23, 2024
dbms/src/main/java/org/polypheny/db/transaction/LockManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the handling of locking for transactions, detects deadlock scenarios and correctly roles back in such cases. Additionally, it removes unnecessary wrapping of errors and generally increases the error messages.
Further, it fixes performance problems of JDBC adapters.
Changes
If applicable, list all changes you introduced to the current architecture and list how the behavior has changed.
Bug Fixes