36 onboard buffer overrun #37

mximp · 2022-10-31T11:48:30Z

#36 added array buffer overrun case from https://github.com/polystat/clang-tidy-mistakes/blob/master/false-negative/buffer-overrun.cpp

mximp · 2022-10-31T14:52:47Z

@APotyomkin please review

mximp · 2022-11-02T08:43:55Z

@AlexPotyomkin @yegor256 please check & merge

mximp · 2022-11-24T08:34:02Z

@yegor256 reminder

yegor256 · 2022-11-24T08:44:07Z

@rultor merge

rultor · 2022-11-24T08:46:25Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-11-24T08:46:48Z

@rultor merge

@mximp @yegor256 Oops, I failed. You can see the full log here (spent 12s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 39102
+ echo '2.0-SNAPSHOT BUILD'
2.0-SNAPSHOT BUILD
+ date
Thu 24 Nov 2022 09:46:38 AM CET
+ uptime
 09:46:38 up 15:24,  0 users,  load average: 0.00, 0.01, 0.00
+ ff=default
+ image=yegor256/rultor-image:1.13.0
+ rebase=false
+ head_branch=master
+ pull_title='36 onboard buffer overrun'
+ author=yegor256
+ directory=
+ head=git@github.com:polystat/awesome-bugs.git
+ pull_id=37
+ fork=git@github.com:mximp/awesome-bugs.git
+ fork_branch=36-onboard-buffer-overrun
+ squash=false
+ vars=('--env=head=git@github.com:polystat/awesome-bugs.git' '--env=pull_id=37' '--env=fork=git@github.com:mximp/awesome-bugs.git' '--env=fork_branch=36-onboard-buffer-overrun' '--env=head_branch=master' '--env=pull_title=36 onboard buffer overrun' '--env=author=yegor256' '--env=scripts=( '\''export '\''\'\'''\''head=git@github.com:polystat/awesome-bugs.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=37'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:mximp/awesome-bugs.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=36-onboard-buffer-overrun'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=36 onboard buffer overrun'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=yegor256'\''\'\'''\'''\'' '\'';'\'' '\''python3 -m pip install --upgrade pip wheel'\'' '\'';'\'' '\''python3 -m pip install -r scripts/requirements.txt'\'' '\'';'\'' '\''python3 -m pip install -e ./scripts'\'' '\'';'\'' '\''sudo apt-get update -y'\'' '\'';'\'' '\''sudo apt-get install -y clang-tidy cmake'\'' '\'';'\'' '\''curl -L -o polystat.jar "https://github.com/polystat/polystat-cli/releases/download/v0.1.11/polystat.jar"'\'' '\'';'\'' '\''curl -L -o j2eo.jar "https://search.maven.org/remotecontent?filepath=org/polystat/j2eo/0.5.3/j2eo-0.5.3.jar"'\'' '\'';'\'' '\''git clone https://github.com/SVF-tools/SVF.git'\'' '\'';'\'' '\''cd SVF'\'' '\'';'\'' '\''source ./build.sh'\'' '\'';'\'' '\''cd ../'\'' '\'';'\'' '\''sudo apt-get install -y cppcheck'\'' '\'';'\'' '\''curl -L -o spotbugs-4.7.0.tgz "https://github.com/spotbugs/spotbugs/releases/download/4.7.0/spotbugs-4.7.0.tgz"'\'' '\'';'\'' '\''gunzip -c spotbugs-4.7.0.tgz | tar xvf -'\'' '\'';'\'' '\''javac -version'\'' '\'';'\'' '\''pdd --file=/dev/null'\'' '\'';'\'' '\''python3 -m source_files_extractor tests temp/sources ""'\'' '\'';'\'' '\''python3 -m build_sources temp/sources build'\'' '\'';'\'' '\''python3 -m clang_tidy -p ./build > results/clang-out.txt'\'' '\'';'\'' '\''cat results/clang-out.txt'\'' '\'';'\'' '\''touch results/polystat-eo-out.txt'\'' '\'';'\'' '\''java -jar polystat.jar eo --in temp/sources/eo --to file=results/polystat-eo-out.txt --sarif'\'' '\'';'\'' '\''cat results/polystat-eo-out.txt'\'' '\'';'\'' '\''java -jar j2eo.jar temp/sources/java -o temp/sources/j2eo'\'' '\'';'\'' '\''touch results/polystat-j2eo-out.txt'\'' '\'';'\'' '\''java -jar polystat.jar eo --in temp/sources/j2eo --to file=results/polystat-j2eo-out.txt --sarif'\'' '\'';'\'' '\''cat results/polystat-j2eo-out.txt'\'' '\'';'\'' '\''python3 -m SVF temp/sources/cpp temp/bc results SVF/Release-build/bin'\'' '\'';'\'' '\''python3 -m cppcheck temp/sources/cpp results'\'' '\'';'\'' '\''python3 -m spotbugs spotbugs-4.7.0/lib/spotbugs.jar temp/sources/java results'\'' '\'';'\'' '\''python3 -m analyze_reports true'\'' '\'';'\'' )')
+ scripts=('export '\''head=git@github.com:polystat/awesome-bugs.git'\''' ';' 'export '\''pull_id=37'\''' ';' 'export '\''fork=git@github.com:mximp/awesome-bugs.git'\''' ';' 'export '\''fork_branch=36-onboard-buffer-overrun'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=36 onboard buffer overrun'\''' ';' 'export '\''author=yegor256'\''' ';' 'python3 -m pip install --upgrade pip wheel' ';' 'python3 -m pip install -r scripts/requirements.txt' ';' 'python3 -m pip install -e ./scripts' ';' 'sudo apt-get update -y' ';' 'sudo apt-get install -y clang-tidy cmake' ';' 'curl -L -o polystat.jar "https://github.com/polystat/polystat-cli/releases/download/v0.1.11/polystat.jar"' ';' 'curl -L -o j2eo.jar "https://search.maven.org/remotecontent?filepath=org/polystat/j2eo/0.5.3/j2eo-0.5.3.jar"' ';' 'git clone https://github.com/SVF-tools/SVF.git' ';' 'cd SVF' ';' 'source ./build.sh' ';' 'cd ../' ';' 'sudo apt-get install -y cppcheck' ';' 'curl -L -o spotbugs-4.7.0.tgz "https://github.com/spotbugs/spotbugs/releases/download/4.7.0/spotbugs-4.7.0.tgz"' ';' 'gunzip -c spotbugs-4.7.0.tgz | tar xvf -' ';' 'javac -version' ';' 'pdd --file=/dev/null' ';' 'python3 -m source_files_extractor tests temp/sources ""' ';' 'python3 -m build_sources temp/sources build' ';' 'python3 -m clang_tidy -p ./build > results/clang-out.txt' ';' 'cat results/clang-out.txt' ';' 'touch results/polystat-eo-out.txt' ';' 'java -jar polystat.jar eo --in temp/sources/eo --to file=results/polystat-eo-out.txt --sarif' ';' 'cat results/polystat-eo-out.txt' ';' 'java -jar j2eo.jar temp/sources/java -o temp/sources/j2eo' ';' 'touch results/polystat-j2eo-out.txt' ';' 'java -jar polystat.jar eo --in temp/sources/j2eo --to file=results/polystat-j2eo-out.txt --sarif' ';' 'cat results/polystat-j2eo-out.txt' ';' 'python3 -m SVF temp/sources/cpp temp/bc results SVF/Release-build/bin' ';' 'python3 -m cppcheck temp/sources/cpp results' ';' 'python3 -m spotbugs spotbugs-4.7.0/lib/spotbugs.jar temp/sources/java results' ';' 'python3 -m analyze_reports true' ';')
+ container=polystat_awesome-bugs_37
+ as_root=false
+ hostname
m2262.contaboserver.net
+ git --version
git version 2.25.1
+ docker --version
Docker version 20.10.21, build baeda1f
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:polystat/awesome-bugs.git repo
Cloning into 'repo'...
Warning: Permanently added the ECDSA host key for IP address '140.82.121.4' to the list of known hosts.
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
'cid' file is absent, most probably the Docker container wasn't started correctly

mximp · 2022-12-05T12:15:52Z

@yegor256 it seems rultor were unable to clone polystat repo. Is there anything needs to be done on rultor's side to set it up correctly?

mximp · 2022-12-09T11:40:19Z

@yegor256 can you assist?

yegor256 · 2022-12-09T11:42:43Z

@rultor merge

rultor · 2022-12-09T11:43:57Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2022-12-09T11:45:29Z

@rultor merge

@mximp @yegor256 Oops, I failed. You can see the full log here (spent 1min)

  File "/usr/local/lib/python3.8/dist-packages/pip/_internal/cli/base_command.py", line 101, in main
    return self._main(args)
  File "/usr/local/lib/python3.8/dist-packages/pip/_internal/cli/base_command.py", line 223, in _main
    self.handle_pip_version_check(options)
  File "/usr/local/lib/python3.8/dist-packages/pip/_internal/cli/req_command.py", line 190, in handle_pip_version_check
    pip_self_version_check(session, options)
  File "/usr/local/lib/python3.8/dist-packages/pip/_internal/self_outdated_check.py", line 236, in pip_self_version_check
    logger.warning("[present-rich] %s", upgrade_prompt)
  File "/usr/lib/python3.8/logging/__init__.py", line 1458, in warning
    self._log(WARNING, msg, args, **kwargs)
  File "/usr/lib/python3.8/logging/__init__.py", line 1589, in _log
    self.handle(record)
  File "/usr/lib/python3.8/logging/__init__.py", line 1599, in handle
    self.callHandlers(record)
  File "/usr/lib/python3.8/logging/__init__.py", line 1661, in callHandlers
    hdlr.handle(record)
  File "/usr/lib/python3.8/logging/__init__.py", line 954, in handle
    self.emit(record)
  File "/usr/local/lib/python3.8/dist-packages/pip/_internal/utils/logging.py", line 179, in emit
    self.handleError(record)
Message: '[present-rich] %s'
Arguments: (UpgradePrompt(old='22.2.2', new='22.3.1'),)
+ python3 -m pip install -r scripts/requirements.txt
Defaulting to user installation because normal site-packages is not writeable
Collecting et-xmlfile==1.1.0
  Downloading et_xmlfile-1.1.0-py3-none-any.whl (4.7 kB)
Collecting openpyxl==3.0.9
  Downloading openpyxl-3.0.9-py2.py3-none-any.whl (242 kB)
\u001b[?25l     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m0.0/242.2 kB\u001b[0m \u001b[31m?\u001b[0m eta \u001b[36m-:--:--\u001b[0m
\u001b[2K     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m242.2/242.2 kB\u001b[0m \u001b[31m8.7 MB/s\u001b[0m eta \u001b[36m0:00:00\u001b[0m
\u001b[?25hCollecting packaging==21.0
  Downloading packaging-21.0-py3-none-any.whl (40 kB)
\u001b[?25l     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m0.0/40.4 kB\u001b[0m \u001b[31m?\u001b[0m eta \u001b[36m-:--:--\u001b[0m
\u001b[2K     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m40.4/40.4 kB\u001b[0m \u001b[31m9.1 MB/s\u001b[0m eta \u001b[36m0:00:00\u001b[0m
\u001b[?25hCollecting parsy==1.3.0
  Downloading parsy-1.3.0-py2.py3-none-any.whl (6.6 kB)
Collecting PyYAML==5.4.1
  Downloading PyYAML-5.4.1-cp38-cp38-manylinux1_x86_64.whl (662 kB)
\u001b[?25l     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m0.0/662.4 kB\u001b[0m \u001b[31m?\u001b[0m eta \u001b[36m-:--:--\u001b[0m
\u001b[2K     \u001b[91m━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m\u001b[91m╸\u001b[0m\u001b[90m━━━━━━━━━━━━━\u001b[0m \u001b[32m430.1/662.4 kB\u001b[0m \u001b[31m13.0 MB/s\u001b[0m eta \u001b[36m0:00:01\u001b[0m
\u001b[2K     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m662.4/662.4 kB\u001b[0m \u001b[31m11.1 MB/s\u001b[0m eta \u001b[36m0:00:00\u001b[0m
\u001b[?25hCollecting pylatex==1.4.1
  Downloading PyLaTeX-1.4.1.tar.gz (84 kB)
\u001b[?25l     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m0.0/85.0 kB\u001b[0m \u001b[31m?\u001b[0m eta \u001b[36m-:--:--\u001b[0m
\u001b[2K     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m85.0/85.0 kB\u001b[0m \u001b[31m12.0 MB/s\u001b[0m eta \u001b[36m0:00:00\u001b[0m
\u001b[?25h  Preparing metadata (setup.py) ... \u001b[?25l-\u0008 \u0008done
\u001b[?25hCollecting pyparsing>=2.0.2
  Downloading pyparsing-3.0.9-py3-none-any.whl (98 kB)
\u001b[?25l     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m0.0/98.3 kB\u001b[0m \u001b[31m?\u001b[0m eta \u001b[36m-:--:--\u001b[0m
\u001b[2K     \u001b[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\u001b[0m \u001b[32m98.3/98.3 kB\u001b[0m \u001b[31m12.0 MB/s\u001b[0m eta \u001b[36m0:00:00\u001b[0m
\u001b[?25hCollecting ordered-set
  Downloading ordered_set-4.1.0-py3-none-any.whl (7.6 kB)
Building wheels for collected packages: pylatex
  Building wheel for pylatex (setup.py) ... \u001b[?25l-\u0008 \u0008done
\u001b[?25h  Created wheel for pylatex: filename=PyLaTeX-1.4.1-py3-none-any.whl size=42809 sha256=d10bd61c89f2a4bdde17b3fd51d39417a628f5ad47e8afd9fe3b271fad44696a
  Stored in directory: /home/r/.cache/pip/wheels/3a/90/79/01e9d0b88370eccbd67125513e90e1b0ef69955e4df991744b
Successfully built pylatex
Installing collected packages: parsy, PyYAML, pyparsing, ordered-set, et-xmlfile, pylatex, packaging, openpyxl
Successfully installed PyYAML-5.4.1 et-xmlfile-1.1.0 openpyxl-3.0.9 ordered-set-4.1.0 packaging-21.0 parsy-1.3.0 pylatex-1.4.1 pyparsing-3.0.9
+ python3 -m pip install -e ./scripts
Defaulting to user installation because normal site-packages is not writeable
Obtaining file:///home/r/repo/scripts
  Preparing metadata (setup.py) ... \u001b[?25l-\u0008 \u0008done
\u001b[31mERROR: Package 'unknown' requires a different Python: 3.8.10 not in '>=3.9'\u001b[0m\u001b[31m
\u001b[0m\u001b[?25hcontainer 6251847b93d4cb416773378740d1a178b08a1c110f2f58f5041bf02d6b6a2b5c is dead
Fri 09 Dec 2022 12:45:23 PM CET

mximp added 3 commits October 28, 2022 19:18

#36 test case for buffer overrun

6921569

#36 added array out of bound case

ce6d727

#36 syntax fix

0b7b705

mximp requested a review from APotyomkin October 31, 2022 14:52

mximp closed this by deleting the head repository Dec 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

36 onboard buffer overrun #37

36 onboard buffer overrun #37

mximp commented Oct 31, 2022

mximp commented Oct 31, 2022

mximp commented Nov 2, 2022

mximp commented Nov 24, 2022

yegor256 commented Nov 24, 2022

rultor commented Nov 24, 2022

rultor commented Nov 24, 2022

mximp commented Dec 5, 2022

mximp commented Dec 9, 2022

yegor256 commented Dec 9, 2022

rultor commented Dec 9, 2022

rultor commented Dec 9, 2022

36 onboard buffer overrun #37

36 onboard buffer overrun #37

Conversation

mximp commented Oct 31, 2022

mximp commented Oct 31, 2022

mximp commented Nov 2, 2022

mximp commented Nov 24, 2022

yegor256 commented Nov 24, 2022

rultor commented Nov 24, 2022

rultor commented Nov 24, 2022

mximp commented Dec 5, 2022

mximp commented Dec 9, 2022

yegor256 commented Dec 9, 2022

rultor commented Dec 9, 2022

rultor commented Dec 9, 2022