Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building errors #111

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix building errors #111

merged 2 commits into from
Oct 6, 2023

Conversation

julesvidal
Copy link
Contributor

Dear Nicolas,

This PR fixes building issues on my Linux:

  • Some template parameters missing
  • Calls to std::is_same_v (replaced with std::is_same::value)

Best,
Jules

@nmellado nmellado added the bug Something isn't working label Oct 6, 2023
@nmellado nmellado merged commit 8cf2836 into poncateam:master Oct 6, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmellado nmellado nmellado approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julesvidal @nmellado