Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphere fitting eigen solver #115

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Fix sphere fitting eigen solver #115

merged 6 commits into from
Oct 31, 2023

Conversation

ThibaultLejemble
Copy link
Collaborator

This PR fixes issue #112:

  • use EigenSolver on C^{-1}A
  • put the solver as class member in case we want to access it
  • add example and documentation

@ThibaultLejemble ThibaultLejemble self-assigned this Oct 18, 2023
@nmellado nmellado force-pushed the fix-sphere branch 2 times, most recently from d667f4e to 451137b Compare October 31, 2023 12:13
@nmellado nmellado linked an issue Oct 31, 2023 that may be closed by this pull request
Sphere fit eigensolver #112
Closed
@nmellado nmellado merged commit f8e54a5 into poncateam:master Oct 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmellado nmellado nmellado approved these changes

Assignees

@ThibaultLejemble ThibaultLejemble

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sphere fit eigensolver
2 participants
@ThibaultLejemble @nmellado