-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fitting] Expose barycenter and add barycenterLocal #141
Conversation
60d0fc4
to
3d64252
Compare
This problem has been identified by @wgoadri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. Not sure to see the side effects of this edit but the local/global clarification is valuable per se.
Would that affect some estimators Leo is testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me. I agree that the old barycenter
was unclear whether it was in local or global space. I also agree that code using the old barycenter
might break, but it should be fine since the change is documented.
It is true that this is a breaking change that will lead to a major release bump (btw we might want to merge it after #143 then). |
1d33be0
to
e65a731
Compare
I updated the changelog to highlight the breaking change. |
Just pushed again to fix a bug when rebasing: I was using old |
In the current version it is not clear that the barycenter is given in local coordinate system.
Todo