Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plane Frame #79

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

add plane Frame #79

wants to merge 15 commits into from

Conversation

jmaleo
Copy link
Contributor

@jmaleo jmaleo commented May 25, 2023

Feature adding the base conversion from plane created from oriented point clouds.

Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.hpp Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlane.h Outdated Show resolved Hide resolved
Ponca/src/Fitting/meanPlaneFit.h Outdated Show resolved Hide resolved
@nmellado
Copy link
Contributor

nmellado commented Jun 9, 2023

@jmaleo please fix compilation errors

@nmellado nmellado changed the title add mean plane add plane Frame Jun 13, 2023
@nmellado
Copy link
Contributor

Thanks, looks nice.

One last remark: could you set m _u and m_v as private, and add a protected setter (e.g. setFrameUV(vector u, vector v), with the documentation explaining how the frame is constructed), and a public getter to each field (e.g., getFrameU() and getFrameV()).

@github-actions
Copy link

Stale pull request message

@github-actions github-actions bot closed this Aug 27, 2023
@nmellado nmellado reopened this Aug 27, 2023
@github-actions github-actions bot closed this Sep 4, 2023
@nmellado nmellado reopened this Sep 4, 2023
@nmellado nmellado added the postponed Temporary postponed (but kept for later) label Oct 3, 2023
@nmellado nmellado marked this pull request as draft October 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed Temporary postponed (but kept for later)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants