Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating dart:html to package:web #507

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Migrating dart:html to package:web #507

merged 1 commit into from
Jun 3, 2024

Conversation

a-h-mzd
Copy link
Contributor

@a-h-mzd a-h-mzd commented May 10, 2024

This PR addresses the following issue: #498

@a-h-mzd a-h-mzd mentioned this pull request May 10, 2024
Closed
amrgetment
amrgetment reviewed May 10, 2024
View reviewed changes
Copy link

@amrgetment amrgetment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update index.html check my PR
https://github.com/miguelpruivo/flutter_file_picker/pull/1481/files

lib/fluttertoast_web.dart
Comment on lines +92 to +94
for (final web.HTMLElement tag in tags) {
web.document.querySelector('head')!.append(tag);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

querySelector has children, why for loop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on how querySelector having children can help us get rid of the for loop? Maybe a code snippet?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, you are right

@a-h-mzd
Copy link
Contributor Author

a-h-mzd commented May 11, 2024

You need to update index.html check my PR https://github.com/miguelpruivo/flutter_file_picker/pull/1481/files

Actually, there is no need to change the example index.html file. The behavior you're referring to is going to change when flutter support for wasm lands on the stable channel. Also making the example project build with wasm is irrelevant to this PR.

@Mr-Pepe
Copy link

Mr-Pepe commented Jun 3, 2024

@ponnamkarthik Any chance to get this merged? :) This is a blocker for WASM builds.

@ponnamkarthik ponnamkarthik merged commit 4fef900 into ponnamkarthik:master Jun 3, 2024
1 check passed
@ponnamkarthik
Copy link
Owner

@Mr-Pepe pushed new version of the pulgin.

Thanks for the PR @a-h-mzd

@Mr-Pepe
Copy link

Mr-Pepe commented Jun 3, 2024

Wow, that was fast! Thank you 🥳

This was referenced Jun 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrgetment amrgetment amrgetment approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-h-mzd @Mr-Pepe @ponnamkarthik @amrgetment