home page animation add #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooranjoyb
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Everything is fine @soykot2910
I'd just need some bug fixes,
- The Animations triggers on page refresh, however they should have been triggered on scroll
- Do something to track user's scroll and components should animate accordingly
|
@pooranjoyb On scroll animation added |
pooranjoyb
requested changes
Oct 9, 2023
There was a problem hiding this comment.
- This one should have the
fadeanimation. Checkout here for reference
- This image should also arrive from the right in the similar way left div arrives.
Rest Everything is perfect. Do these chanegs and I'll merge them 😄
|
@pooranjoyb fade animation added |
|
Nice Work @soykot2910 🚀 |
pooranjoyb
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.