Bugfix ic2 voltage tier #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs in Recipes - fixes portablejim#15
IC2's Api expects LV=>1, MV=>2, HV=>3... PowerConverter's VoltageIndex begins as 0=>LV, 1=>MV, 2=>HV .. which resulted in wrong Voltage Tier has been repoted to ic2.
|
This does not seem to be merged in the near future ._. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed IC2 API Usage:
IC2's VoltageTier begins at 1 => LV, .. 2 => MV, 3 => HV, 4 => EV .. etc
PowerConverters's voltageIndex begins at 0 => LV, 2 => MV, 3 => HV .. etc
So Powerconverters will report the wrong Voltage Tier (HV Consumer gets reported as MV Consumer .. etc)
Which may result in unexpected behavior (especially when using Aroma1997's Uncomplication Mod which restores the old E-Net @ Current IC2)