Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(update): timeout increased for watcher [EE-6580] #19

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix(update): timeout increased for watcher [EE-6580] #19

merged 4 commits into from
Jan 23, 2024

Conversation

prabhat83
Copy link
Contributor

@prabhat83 prabhat83 commented Jan 23, 2024 •
edited by jira bot
Loading

@prabhat83 prabhat83 changed the title fix: add retires to wait for deployment [EE-6580] fix(update): add retires to wait for deployment [EE-6580] Jan 23, 2024
@prabhat83 prabhat83 changed the title fix(update): add retires to wait for deployment [EE-6580] fix(update): add retries to wait for deployment [EE-6580] Jan 23, 2024
prabhat83
prabhat83 commented Jan 23, 2024
View reviewed changes
kubernetes/update.go Outdated Show resolved Hide resolved
hookenz
hookenz suggested changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@hookenz hookenz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. I don't agree with the retry loop here.
But also the error message could be better. Discuss with me if you disagree.

kubernetes/update.go Outdated Show resolved Hide resolved
kubernetes/update.go Outdated Show resolved Hide resolved
kubernetes/update.go Outdated Show resolved Hide resolved
@prabhat83 prabhat83 changed the title fix(update): add retries to wait for deployment [EE-6580] fix(update): timeout increased for watcher [EE-6580] Jan 23, 2024
@hookenz hookenz merged commit 902f489 into develop Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hookenz hookenz hookenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prabhat83 @hookenz