Fix: Allow shinylive-r chunks to create files in subdirectories
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
approved these changes
Aug 8, 2024
|
Thank you! |
|
@gadenbuie Please add a news entry and feel free to merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
build_app_resources()so that it can create files in subdirectories, e.g.This would previously fail because
writeLines()would write to"{appdir}/R/load_data.R"but{appdir}/Rdoesn't exist yet.While here I also added a check, after normalizing
file$name, to make sure that file names are specified relative to the app directory and don't escape upwards.