-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Wasm R package binary assets downloading when exporting a Shinylive app #131
Conversation
Note: this will break compatibility with older shinylive assets. Below I note what the failure looks like: This PR's
|
Instead, show a warning asking the user to upgrade their Shinylive assets to a compatible version.
Related py-shinylive PR: posit-dev/py-shinylive#42. Onced merged, the integration test here should work again. This should be less of an issue in the future once posit-dev/py-shinylive#33 is implemented, because we can just override using |
posit-dev/py-shinylive#42 has been merged, so latest @schloerke / @gadenbuie How do we feel about switching out this line in the integration test to pull from
Otherwise I don't think the test will pass until the next |
I don't mind. I'd really like for |
Lets disable it for now. Thank you |
filename = glue::glue("{pkg}_{ver}.js.metadata"), | ||
url = glue::glue("{contrib}/{pkg}_{ver}.js.metadata") | ||
filename = glue::glue("{pkg}_{ver}.tgz"), | ||
url = glue::glue("{contrib}/{pkg}_{ver}.tgz") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This change switches from downloading the older webR VFS format to the newer (single .tgz
file) format. Both repo.r-wasm.org and R-Universe are already publishing packages in this new format.
I've disabled the test. We can re-enable it once Thanks, I think this is now all ready for review for merging. |
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
This PR contains three changes to improve the bundling of static assets for loading R package binaries into webR.
.tgz
formatted R package binaries, support for which is introduced in webR 0.4.2 (Add support for mounting.tgz
files with filesystem metadata appended r-wasm/webr#477). This additionally fixes bundling R-Universe packages as static assets, as it now also serves packages in this new format.library.data.gz
.This relies on using webR v0.4.2, and so requires a new version of the Shinylive assets. So, I will open a linked PR on posit-dev/shinylive and convert this from a Draft PR once new assets are ready.