Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing download timeout #30

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Increasing download timeout #30

merged 2 commits into from
Nov 30, 2023

Conversation

dgkf
Copy link
Contributor

@dgkf dgkf commented Oct 27, 2023

My quarto presentations error with a utils::download.file timeout (defaults to 60s, expecting ~4MB/s for the 250MB shinylive archive). Not sure if it's limited by my internet or the github release artifacts server throttling downloads, but regardless this exceeds the guidelines in ?utils::download.file:

It is unrealistic to require download times of less than 1s/MB.

Just temporarily bumping the download timeout to accommodate the file size. Not sure how much you want to engineer this, but this could even catch the error and check to see if it failed due to a timeout, and if so suggest rerunning with R_DEFAULT_INTERNET_TIMEOUT increased.

@schloerke
Copy link
Collaborator

Thank you!

For now, we'll leave it as is. In the future, I'll update {httr}/{httr2} to retrieve the file so that a progress bar is displayed.

@schloerke schloerke merged commit 5561116 into posit-dev:main Nov 30, 2023
12 checks passed
@schloerke schloerke mentioned this pull request Nov 30, 2023
Merged
schloerke added a commit that referenced this pull request Dec 1, 2023
@schloerke
Merge branch 'main' into rc-v0.1.1
a84b8b7 
* main:
  feat: Use `httpuv::runStaticServer(dir)` instead of `{plumber}` (#40)
  feat: Use `{httr2}` to download assets to avoid timeout and give a progress bar (#39)
  Increasing download timeout (#30)
  Bump shinylive web assets to 0.2.3 (#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgkf @schloerke