Don't auto-run if app file is empty

posit-dev · Jul 29, 2024 · 38fe829 · 38fe829
1 parent 1ce625f
commit 38fe829
Showing 1 changed file with 14 additions and 12 deletions.
diff --git a/src/Components/App.tsx b/src/Components/App.tsx
@@ -399,12 +399,7 @@ export function App({
               terminalMethods={terminalMethods}
               viewerMethods={viewerMethods}
               utilityMethods={utilityMethods}
-              runOnLoad={currentFiles.some(
-                (file) =>
-                  file.name === "app.py" ||
-                  file.name === "app.R" ||
-                  file.name === "server.R",
-              )}
+              runOnLoad={isRunnableApp(currentFiles)}
               updateUrlHashOnRerun={appOptions.updateUrlHashOnRerun}
               appEngine={appEngine}
             />
@@ -454,12 +449,7 @@ export function App({
               terminalMethods={terminalMethods}
               viewerMethods={viewerMethods}
               utilityMethods={utilityMethods}
-              runOnLoad={currentFiles.some(
-                (file) =>
-                  file.name === "app.py" ||
-                  file.name === "app.R" ||
-                  file.name === "server.R",
-              )}
+              runOnLoad={isRunnableApp(currentFiles)}
               updateUrlHashOnRerun={appOptions.updateUrlHashOnRerun}
               appEngine={appEngine}
             />
@@ -774,6 +764,18 @@ const propertyOfAppOptions = function <AppOptions>(name: keyof AppOptions) {
   return name;
 };
 
+// Return true if the FileContent[] contains an app.py, app.R, or server.R that
+// is non-empty.
+function isRunnableApp(files: FileContent[]): boolean {
+  return files.some(
+    (file) =>
+      (file.name === "app.py" ||
+        file.name === "app.R" ||
+        file.name === "server.R") &&
+      file.content !== "",
+  );
+}
+
 // =============================================================================
 // Code templates
 // =============================================================================