Use Pyodide's version of IPython #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also updated all the packages in shinylive_lock.json. |
This was referenced Jul 24, 2024
cpsievert
reviewed
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of Pyodide come with IPython 8.23.0. Previous versions did not, and we needed to shim in a stub for IPython. This PR makes it use the Pyodide version of IPython. It also removes an entry in shinylive_lock.json that should not have been there (and didn't have an effect anyway, because our IPython shims took precedence over this entry.)
@cpsievert It might be worthwhile to run
make update_packages_lockand see if anything breaks.