Skip to content

Commit

Permalink
fix Werkzeug 2.1.x compatibility
Browse files Browse the repository at this point in the history
- fix httpbin/core.py: use Responce class instead of BaseResponse
see: pallets/werkzeug#2276
- fix tests: TestClient doesn't provide 'Content-Length' header anymore
see: pallets/werkzeug#2347
  • Loading branch information
dshein-alt committed Sep 26, 2022
1 parent f8ec666 commit c3ad946
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions httpbin/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
from six.moves import range as xrange
from werkzeug.datastructures import WWWAuthenticate, MultiDict
from werkzeug.http import http_date
from werkzeug.wrappers import BaseResponse
from werkzeug.wrappers import Response
from werkzeug.http import parse_authorization_header
from flasgger import Swagger, NO_SANITIZER

Expand Down Expand Up @@ -77,7 +77,7 @@ def jsonify(*args, **kwargs):


# Prevent WSGI from correcting the casing of the Location header
BaseResponse.autocorrect_location_header = False
Response.autocorrect_location_header = False

# Find the correct template folder when running from a different location
tmpl_dir = os.path.join(os.path.dirname(os.path.abspath(__file__)), "templates")
Expand Down
4 changes: 2 additions & 2 deletions test_httpbin.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ def test_get(self):
data = json.loads(response.data.decode('utf-8'))
self.assertEqual(data['args'], {})
self.assertEqual(data['headers']['Host'], 'localhost')
self.assertEqual(data['headers']['Content-Length'], '0')
# self.assertEqual(data['headers']['Content-Length'], '0')
self.assertEqual(data['headers']['User-Agent'], 'test')
# self.assertEqual(data['origin'], None)
self.assertEqual(data['url'], 'http://localhost/get')
Expand All @@ -162,7 +162,7 @@ def test_anything(self):
data = json.loads(response.data.decode('utf-8'))
self.assertEqual(data['args'], {})
self.assertEqual(data['headers']['Host'], 'localhost')
self.assertEqual(data['headers']['Content-Length'], '0')
# self.assertEqual(data['headers']['Content-Length'], '0')
self.assertEqual(data['url'], 'http://localhost/anything/foo/bar')
self.assertEqual(data['method'], 'GET')
self.assertTrue(response.data.endswith(b'\n'))
Expand Down

0 comments on commit c3ad946

Please sign in to comment.