Fix disabling of location header autocorrect for werkzeug 2+ #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labs#647) In werkzeug 2.0.0 and later, the Location header autocorrection moved from BaseResponse to Response, so we need to set `autocorrect_location_header = False` in `Response` not `BaseResponse`. For now let's just set it in both to be safe, this doesn't cause any errors at least with 1.0.1 and 2.0.1. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
fix-werkzeug2-autocorrect
branch
from
c5f411d
to
ccd417e
Compare
|
Fixes #647 |
MikeRalphson
approved these changes
Aug 27, 2021
|
@kinlane This PR is a pre-requisite for getting the tests running again when we move them to GitHub Actions - see https://github.com/MikeRalphson/httpbin/actions/runs/1174257560 |
|
Closing in favor of #674 , as setting both isn't valid any more (plus this wasn't doing it entirely right). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In werkzeug 2.0.0 and later, the Location header autocorrection
moved from BaseResponse to Response, so we need to set
autocorrect_location_header = FalseinResponsenotBaseResponse. For now let's just set it in both to be safe,this doesn't cause any errors at least with 1.0.1 and 2.0.1.
Signed-off-by: Adam Williamson awilliam@redhat.com