fix: add prepublish #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
Signed-off-by: ryanwolhuter <dev@ryanwolhuter.com>
acaldas
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is easy to forget to run
yarn buildwhen publishing the lib.According to the npm scripts docs, the current best practice for this is to use the
prepublishOnlyscript for this. Thepreparescript also runs onyarn installwhich is not what we want.I have also modified the spacing in the rootIndex template. We want to run
yarn generatebefore linting in thedocument-model-libs, and those index files are not part of /gen and are therefore seen by eslint and prettier. I have updated the spacing to match what prettier wants, because otherwise the generated files would keep on triggering the linting.