Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicated react instance #582

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

gpuente
Copy link

@gpuente gpuente commented Oct 28, 2024

Description:

  • use react instance from document-model-boilerplate when using studio build (this fixes duplicated react instances)
  • when building connect for web deployment, use react importmap (same behavior as before)
  • exclude design-system and scalars packages from connect studio build (this packages are provided by document-model-boilerplate)

@gpuente gpuente force-pushed the fix-duplicated-react-instance branch from 14f173b to 954379f Compare October 28, 2024 17:54
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:56pm

@@ -5,20 +5,10 @@
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Powerhouse Connect</title>
<base href="/">
%VITE_IMPORT_REACT_SCRIPT%
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using this instead of vite-html-plugin (it doesn't work for some weird reason, we need to investigate what's wrong with this dep)

@gpuente gpuente merged commit 2943df3 into develop Oct 28, 2024
5 of 6 checks passed
@gpuente gpuente deleted the fix-duplicated-react-instance branch October 28, 2024 18:12
Copy link

🎉 This PR is included in version 1.0.0-dev.151 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants