feat: force usage of env variables when vite-envs.sh execution fails #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acaldas
approved these changes
Nov 6, 2024
gpuente
deleted the
588-fix-not-linked-document-models-and-editors-when-running-studio-with-powershell-windows
branch
|
🎉 This PR is included in version 1.0.0-dev.158 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
MacOS and Linux: No changes
in Windows:
if running connect from git bash or something similar, the app follows the normal flow (runs vite-envs.sh to define the env variables)
if running in PowerShell or something similar, the flow is executed as follow (before start the dev server):
index.htmlindex.htmlby removing default base64 values for LOCAL_DOCUMENT_MODELS and LOCAL_DOCUMENT_EDITORS inenvWithValuesInBase64object (this forces the devServer to take the values from process.env)the backup file is restored before running the vite-envs.sh, this allows windows users to change between powershell and bash compatible command lines