Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename DanglingLine to BoundaryLine #2569

Closed
wants to merge 3 commits into from
Closed

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented May 12, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Rename

What is the current behavior?

DanglingLine

What is the new behavior (if this is a feature change)?
BoundaryLine: it's not always dangling as the DanglingLine/BoundaryLine is kept even when paired/merged

Does this PR introduce a breaking change or deprecate an API? yes

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup added the Breaking Change API is broken label May 12, 2023
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@annetill
Copy link
Member

See issue #2850

@annetill annetill closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change API is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants