Cgmes active reactive regulating control #2995

nemanja-st · 2024-04-30T12:51:07Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #2920 '

Does this PR introduce a breaking change or deprecate an API?

Yes
No

Other information:
ACTIVE_POWER and CURRENT_LIMITER are already implemented for PSTs.

nemanja-st · 2024-05-10T09:19:41Z

Issues observed for this PR:

StaticVarCompensator:
- When StaticVarCompensatorRegulationMode is OFF and regulatingTerminal is remote, RegulatingControl is always exported with enabled set to false.
- When StaticVarCompensatorRegulationMode is OFF and regulatingTerminal is local, RegulatingControl is never exported.
ShuntCompensator:
- When voltageRegulatorOn is false and regulatingTerminal is remote, RegulatingControl is always exported with enabled set to false.
- When voltageRegulatorOn is false and regulatingTerminal is local, RegulatingControl is never exported.
Implementation in commit d75dacb will need to be propagated to TC export in SV, if user exports only SV cimxml file.

sonarcloud · 2024-05-10T09:42:45Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

annetill · 2024-05-15T07:20:17Z

cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/EquipmentExport.java

+ private static String getSvcMode(StaticVarCompensator svc) {
+ String mode = RegulatingControlEq.REGULATING_CONTROL_VOLTAGE;
+ StaticVarCompensator.RegulationMode regulationMode = svc.getRegulationMode();
+ // FIXME: remove RegulationMode.OFF when #2790 is done


#2790 will not be available soon because it leads to an increase of iidm version. Maybe in June, but no sure at all. Do you have a unit test with a OFF mode but valid values for both voltage and reactive power control values? What is exported then?

marqueslanauja · 2024-05-31T14:11:05Z

...s/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportContext.java

@@ -523,7 +523,7 @@ private void addIidmMappingsShuntCompensators(Network network) {
 continue;
 }
 String regulatingControlId = shuntCompensator.getProperty(Conversion.CGMES_PREFIX_ALIAS_PROPERTIES + REGULATING_CONTROL);
- if (regulatingControlId == null && (shuntCompensator.isVoltageRegulatorOn() || !Objects.equals(shuntCompensator, shuntCompensator.getRegulatingTerminal().getConnectable()))) {
+ if (regulatingControlId == null && SteadyStateHypothesisExport.isValidVoltageSetpoint(shuntCompensator.getTargetV())) {
 regulatingControlId = namingStrategy.getCgmesId(ref(shuntCompensator), Part.REGULATING_CONTROL);


Maybe create also the control when the regulating control is remote. If cgmes EQ file is imported (no SSH file), then only the regulating terminal is defined, given that the setpoint is in the SSH file. Better do not lose the regulating control in this case if the iidm model is exported. In iidm regulating terminal null is the same as local control, then only if the regulating control is remote we have to export it.

if (regulatingControlId == null && (SteadyStateHypothesisExport.isValidVoltageSetpoint(shuntCompensator.getTargetV()) || !Objects.equals(shuntCompensator, shuntCompensator.getRegulatingTerminal().getConnectable()))) {

This is RC creation from scratch (regulatingControlId == null) so it comes down to deciding if Shunt has voltage regulating capability from IIDM.
If targetV is not set, in case of full CGMES export from IIDM, SSH will have incorrect values for the control.

If the targetV is not set, the validation level is EQUIPMENT and does not make sense to export the SSH file.
I prefer to export properly the EQ file, including the control, in concordance with the validation level.

marqueslanauja · 2024-05-31T14:17:32Z

...s/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/CgmesExportContext.java

+ if (regulatingControlId == null && (
+ svc.getRegulationMode() == StaticVarCompensator.RegulationMode.VOLTAGE ||
+ svc.getRegulationMode() == StaticVarCompensator.RegulationMode.REACTIVE_POWER ||
+ validVoltageSetpoint && !validReactiveSetpoint || !validVoltageSetpoint && validReactiveSetpoint)) {
 regulatingControlId = namingStrategy.getCgmesId(ref(svc), Part.REGULATING_CONTROL);


In concordance with the previous comment, we can export it if:

if (regulatingControlId == null && (validVoltageSetpoint || validReactiveSetpoint || !Objects.equals(svc, svc.getRegulatingTerminal().getConnectable()))) {

Again, this is related to RC creation from scratch (no CGMES import).
In CGMES, SVC must have a RC in order to function (SVC parameters regarding control should be ignored). This is valid for local and remote controls.
In this implementation, we avoid exporting RC only when regulationMode is not set and we have both voltage and reactive targets (it's not clear which to use).

I am in favor of exporting the maximum information if the information is valid. In this case, I prefer to export the voltage control as disabled than do not export anything, but of course both options are valid.

We have a use case where we export only an EQ file, without SSH file.

marqueslanauja · 2024-05-31T14:47:40Z

cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/EquipmentExport.java

+ if (rrpc != null) {
+ regulatingTerminal = rrpc.getRegulatingTerminal();
+ mode = RegulatingControlEq.REGULATING_CONTROL_REACTIVE_POWER;
+ }
 switch (cgmesOriginalClass) {


My proposal:

RemoteReactivePowerControl rrpc = generator.getExtension(RemoteReactivePowerControl.class); String mode = getGeneratorRegulatingControlMode(generator, rrpc); Terminal regulatingTerminal = mode.equals(RegulatingControlEq.REGULATING_CONTROL_VOLTAGE) ? generator.getRegulatingTerminal() : rrpc.getRegulatingTerminal();

private static String getGeneratorRegulatingControlMode(Generator generator, RemoteReactivePowerControl rrpc) { if (rrpc == null) { return RegulatingControlEq.REGULATING_CONTROL_VOLTAGE; } boolean enabledVoltageControl = generator.isVoltageRegulatorOn(); boolean enabledReactivePowerControl = rrpc.isEnabled(); if (enabledVoltageControl) { return RegulatingControlEq.REGULATING_CONTROL_VOLTAGE; } else if (enabledReactivePowerControl) { return RegulatingControlEq.REGULATING_CONTROL_REACTIVE_POWER; } else { boolean validVoltageSetpoint = SteadyStateHypothesisExport.isValidVoltageSetpoint(generator.getTargetV()); if (validVoltageSetpoint) { return RegulatingControlEq.REGULATING_CONTROL_VOLTAGE; } else { return RegulatingControlEq.REGULATING_CONTROL_REACTIVE_POWER; } } }

We can define the getGeneratorRegulatingControlMode method in the CgmesExportUtil class and use it during the SSH export to be coherent with the EQ export.

The difficulty here is in priorities: Is the RRPC extension priority or voltage control?

Example: rrpc exists, voltage control is enabled -> We export voltage control, regardless of rrpc status.

Since rrpc has to be created explicitly as an extension, assumption is that it has the priority.
Therefore, if rrpc is there, we ignore voltage control completely and only use rrpc parameters.

If the reactive power control extension is present and enabled, it does not override the voltage control if enabled. Maybe it is a mistake but it is what is developed inside open loadflow.

I prefer to select the control priority using the electrical information rather than the software information. The final user, in most of the cases, will not know how the model is internally implemented. Then, if both controls have the same valid attributes I prefer to export the voltage control. But as before, both options are valid.

marqueslanauja · 2024-05-31T14:57:02Z

cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/EquipmentExport.java

+ }
+ return mode;
+ }
+
 private static void writeLines(Network network, Map<Terminal, String> mapTerminal2Id, String cimNamespace, String euNamespace, String valueAttributeName, String limitTypeAttributeName, String limitKindClassName, boolean writeInfiniteDuration, XMLStreamWriter writer, CgmesExportContext context) throws XMLStreamException {


My proposal:

private static String getSvcMode(StaticVarCompensator svc) { if (svc.getRegulationMode().equals(StaticVarCompensator.RegulationMode.VOLTAGE)) { return RegulatingControlEq.REGULATING_CONTROL_VOLTAGE; } else if (svc.getRegulationMode().equals(StaticVarCompensator.RegulationMode.REACTIVE_POWER)) { return RegulatingControlEq.REGULATING_CONTROL_REACTIVE_POWER; } else { if (SteadyStateHypothesisExport.isValidReactivePowerSetpoint(svc.getReactivePowerSetpoint())) { return RegulatingControlEq.REGULATING_CONTROL_VOLTAGE; } else { return RegulatingControlEq.REGULATING_CONTROL_REACTIVE_POWER } } }

We can also define the getSvcMode method in the CgmesExportUtil class and use it during the SSH export to be coherent with the EQ export.

Same comment as above, when SVC control mode is not defined, and we have valid voltage and reactive targets, the control shouldn't be exported.
But I agree it should be a common method in CgmesExportUtil.

I am in favor of exporting the maximum information and in this case I prefer to export the voltage control as disabled but both options are valid.

marqueslanauja · 2024-05-31T15:00:29Z

cgmes/cgmes-conversion/src/main/java/com/powsybl/cgmes/conversion/export/EquipmentExport.java

- // Regulating control mode is always "voltage"
- TapChangerEq.writeControl(cgmesRegulatingControlId, controlName, RATIO_TAP_CHANGER_REGULATION_MODE_VOLTAGE, terminalId, cimNamespace, writer, context);
+ String tccMode = (rtc.getRegulationMode() == RatioTapChanger.RegulationMode.REACTIVE_POWER) ? RATIO_TAP_CHANGER_REGULATION_MODE_REACTIVE_POWER : RATIO_TAP_CHANGER_REGULATION_MODE_VOLTAGE;
+ TapChangerEq.writeControl(cgmesRegulatingControlId, controlName, tccMode, terminalId, cimNamespace, writer, context);
 regulatingControlsWritten.add(cgmesRegulatingControlId);


We can use a method to obtain the tccMode and define it in the CgmesExportUtil class and use it during the SSH export to be always coherent with the EQ export.

marqueslanauja · 2024-05-31T15:05:51Z