Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Asymmetrical line and two windings transformer extensions #3004

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

annetill
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Yes, a PR on open-loadlfow side: powsybl/powsybl-open-loadflow#806

What kind of change does this PR introduce?

For the moment, we have two types of line and two windings transformer extensions: one for Fortescue data and another one for three phase data (called "asymmetrical").
One all needed data are modeled, a nice solution should be to have only one extension for Fortescue data and for three phase data, each object Fortescue and `` ThreePhase` seen as an optional object. But first, focus on modeling.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill requested a review from JB-H May 10, 2024 07:04
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

annetill and others added 3 commits June 11, 2024 16:38
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
74.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@annetill annetill requested a review from geofjamg June 12, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant