Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatteryShortCircuit extension #3062

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

colinepiloquet
Copy link
Contributor

@colinepiloquet colinepiloquet commented Jun 10, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

New extension

What is the new behavior (if this is a feature change)?
New extension for batteries to store the short-circuit data. It works exactly as the one for generators.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@colinepiloquet colinepiloquet marked this pull request as ready for review June 10, 2024 10:42
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
…ortCircuits

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
@olperr1 olperr1 self-requested a review June 11, 2024 15:20
colinepiloquet and others added 6 commits June 12, 2024 10:57
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>
…enerator kind

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Copy link

sonarcloud bot commented Jun 14, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants